refactor: prevent logo click reloading homepage if already there #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here Depending on your design philosophy, clicking the logo should not do anything if you are already where it takes you. https://ux.stackexchange.com/a/55642 The conditional could be inside the href property, which would be DRY but also harder to read: {% url 'index' as index_url %} <a class="navbar-brand" href="{% if request.path == index_url %}#{% else %}{{ index_url }}{% endif %}">
Depending on your design philosophy, clicking the logo should not do anything if you are already where it takes you. https://ux.stackexchange.com/a/55642
davidfischer
requested changes
May 24, 2024
There was a problem hiding this comment.
This is only necessary if you agree with this comment about it being a design error. There's also the very small impact to bandwidth of an unnecessary page load (pretty insignificant for the site's traffic, though).
I don't feel particularly strongly one way or the other. I'd be fine merging this if we can work out the issues but I don't mind the current functionality either.
A different option is to keep the anchor tag and only adjust the href to "#". This tells users that the logo is clickable without reloading the page.
Given the issues with sizing, that might be a better solution. It also simplifies the {% if %}/{% else %} logic.
Co-authored-by: David Fischer <[email protected]>
The image no longer needs an id because there is no CSS targeting it.
davidfischer
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only necessary if you agree with this comment about it being a design error. There's also the very small impact to bandwidth of an unnecessary page load (pretty insignificant for the site's traffic, though).
A different option is to keep the anchor tag and only adjust the href to "#". This tells users that the logo is clickable without reloading the page.