Database driven organizers page #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add code migration - Fix linting - Remove inactive organizers
|
Here's a CSV to easily copy/paste the names and Meetup URLs in /admin/. I don't know who is considered active so I sorted the list based on "Last visited" on Meetup. |
Jer-Pha
reviewed
May 31, 2024
davidfischer
commented
May 31, 2024
Remove organizer description for now
Jer-Pha
reviewed
May 31, 2024
- Add a docker compose environment with Redis and Postgres - Add django-storages for storing media files in S3/R2
|
I created a separate PR (#158) that merges into this one. That PR sets up Docker Compose which I really wanted in order to test this PR with Postgres and a custom storage backend. The custom media storage backend is what I'm planning to use to store organizer photos in something like S3 (or more specifically Cloudflare R2). This PR I think is ready to review/merge and it could be merged without merging the other. |
- Set both `MEDIA_URL` and `AWS_S3_CUSTOM_DOMAIN`. This ensures that both using `MEDIA_URL` or using `file.url` work well
Thanks for the review. I asked in discord but I'll probably merge #158 today or tomorrow and deploy this. I don't want it to sit around too long. |
…se-media-storage Use docker compose for debugging production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #155.
Fixes #64.
Screenshot
Deploying
This PR adds our first migration needed for the site. As with any kind of migration, after this is merged, somebody (probably me) will need to run this migration on the production database.