Skip to content

Update dependency gradle to v8 #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 6, 2023
Merged

Update dependency gradle to v8 #1880

merged 9 commits into from
Mar 6, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 20, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
gradle (source) major 7.6 -> 8.0.1

Release Notes

gradle/gradle

v8.0.1: 8.0.1

This is a patch release for 8.0. We recommend using 8.0.1 instead of 8.0.

It fixes the following issues:

  • #​21551 - Document integration of Scala plugin with toolchains and problems with target flag
  • #​23888 - --no-rebuild suddenly gone without new deprecation cycle and without the reason for its undeprecation being void
  • #​23905 - Gradle 8.0 fails Scala build with isBlank not found in String class error

Read the Release Notes

Upgrade Instructions

Switch your build to use Gradle 8.0.1 by updating your wrapper:

./gradlew wrapper --gradle-version=8.0.1

See the Gradle 7.x upgrade guide to learn about deprecations, breaking changes and other considerations when upgrading to Gradle 8.0.1.

Reporting Problems

If you find a problem with this release, please file a bug on GitHub Issues adhering to our issue guidelines.
If you're not sure you're encountering a bug, please use the forum.


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liquibase-gradle-plugin is not compatible with Gradle 8: liquibase/liquibase-gradle-plugin#101

@renovate renovate bot force-pushed the renovate/gradle-8.x branch from 755ab03 to 1a33c3c Compare February 20, 2023 17:37
@nulls
Copy link
Member

nulls commented Feb 20, 2023

liquibase-gradle-plugin is not compatible with Gradle 8: liquibase/liquibase-gradle-plugin#101

Do we need this plugin? Maybe migrate to liquibase/liquibase:4.15 as we do for prod?
We deploy mysql to local docker, we can also run liquibase as pod on docker too. It also fix the problem with Java 17 for liquibase plugin

@renovate renovate bot force-pushed the renovate/gradle-8.x branch from 1a33c3c to 6febf64 Compare February 20, 2023 20:54
@renovate renovate bot force-pushed the renovate/gradle-8.x branch from 6febf64 to 240c83e Compare February 20, 2023 21:21
@renovate
Copy link
Contributor Author

renovate bot commented Feb 21, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@petertrr
Copy link
Member

petertrr commented Feb 21, 2023

Do we need this plugin? Maybe migrate to liquibase/liquibase:4.15 as we do for prod? We deploy mysql to local docker, we can also run liquibase as pod on docker too. It also fix the problem with Java 17 for liquibase plugin

Yes, I think it would make sense. We can create a docker run command and wrap it into Gradle's Exec just as we do with other docker-related tasks.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1880 (737d264) into master (0437441) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 737d264 differs from pull request most recent head df245b4. Consider uploading reports for the commit df245b4 to get more accurate results

@@             Coverage Diff              @@
##             master    #1880      +/-   ##
============================================
- Coverage     34.35%   34.18%   -0.18%     
  Complexity      592      592              
============================================
  Files           312      311       -1     
  Lines          7781     7776       -5     
  Branches        751      747       -4     
============================================
- Hits           2673     2658      -15     
- Misses         4920     4930      +10     
  Partials        188      188              
Impacted Files Coverage Δ
...m/saveourtool/save/demo/config/ConfigProperties.kt 0.00% <0.00%> (-60.00%) ⬇️
.../save/backend/controllers/DemoManagerController.kt 7.37% <0.00%> (-4.79%) ⬇️
...backend/storage/TestsSourceSnapshotS3KeyManager.kt 46.66% <0.00%> (-3.34%) ⬇️
...veourtool/save/backend/storage/FileS3KeyManager.kt 28.57% <0.00%> (-3.25%) ⬇️
...rtool/save/orchestrator/config/ConfigProperties.kt 97.61% <0.00%> (-0.11%) ⬇️
...in/kotlin/com/saveourtool/save/demo/entity/Demo.kt 0.00% <0.00%> (ø)
...n/kotlin/com/saveourtool/save/demo/config/Beans.kt 0.00% <0.00%> (ø)
...lin/com/saveourtool/save/demo/entity/GithubRepo.kt 0.00% <0.00%> (ø)
...lin/com/saveourtool/save/demo/utils/SystemUtils.kt 0.00% <0.00%> (ø)
...n/com/saveourtool/save/demo/service/DemoService.kt 0.00% <0.00%> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kgevorkyan
Copy link
Member

@nulls could we merge this?

@petertrr
Copy link
Member

I've started some initial work on replacing liquibase-gradle-plugin with a container in #1897. Until then, we won't be able to use liquibase locally with Gradle 8, which blocks this PR.

@nulls nulls mentioned this pull request Mar 6, 2023
@nulls
Copy link
Member

nulls commented Mar 6, 2023

@nulls could we merge this?

now we can, will resolve conflict and merge

@nulls nulls self-assigned this Mar 6, 2023
@nulls nulls enabled auto-merge (squash) March 6, 2023 12:21
@nulls nulls merged commit 34c2653 into master Mar 6, 2023
@nulls nulls deleted the renovate/gradle-8.x branch March 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants