Handle *.sol files that are invalid Solidity #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a nice bug in #147 which this fixes. In order to remove
constant
from all functions for instrumentation to take place, including those imported from./node_modules
, I ran the (increasingly badly named...) preprocessor over all.sol
files that we find in the tree. Unfortunately, if we're usingcopyNodeModules:true
, then that includes thesolidity-coverage
repository, which includes SimpleError.sol, which deliberately has a syntax error in it! This caused an uncaught error to be thrown, andsolidity-coverage
to fail to run.I did think about just skipping
SimpleError.sol
itself, but don't want to be in the position where we break if any other package installed uses.sol
files that aren't Solidity. I therefore leave any*.sol
files that fail to parse alone, and generate a warning in case this is unexpected by the user.SimpleError.sol
is now added to the truffle mock in order to prevent a regression along these lines.Fixes #155