Skip to content

Fix pre/post strategy for modifier coverage #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Jan 5, 2021

PR fixes two problems discovered running dForceLending

  • Modifier branches were not isolated from reverts downstream from them, resulting in false branch hits. New strategy is to have the post-condition as its own modifier, instead of positioning it after the _;
  • Matrix is not being generated correctly when only line coverage is enabled. Not certain what's going wrong here, just disabled the disabling for now since there's no obvious slowdown on a project that size.

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #595 (d79dfa6) into experimental-options (7a5b10f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           experimental-options     #595      +/-   ##
========================================================
- Coverage                 99.12%   99.11%   -0.02%     
========================================================
  Files                        22       22              
  Lines                      1146     1133      -13     
========================================================
- Hits                       1136     1123      -13     
  Misses                       10       10              
Impacted Files Coverage Δ
plugins/resources/plugin.utils.js 97.64% <ø> (-0.14%) ⬇️
lib/injector.js 100.00% <100.00%> (ø)
lib/registrar.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5b10f...d79dfa6. Read the comment docs.

@cgewecke cgewecke merged commit 5ab4857 into experimental-options Jan 5, 2021
@cgewecke cgewecke deleted the dforce-fixes branch January 5, 2021 23:15
@cgewecke cgewecke mentioned this pull request Jan 5, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants