Fix favicon on API docs not rendered on Google Chrome #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ochrons Opinion on this? You're our master of asset size :) |
|
300kB sounds awfully lot for a favicon. It should be converted to a smaller size, say 64x64 which would make it under 3kB. The current is 60kB and it's way too big as well :) |
|
@ochrons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses scala-js/scala-js#1701
HTML of API pages, e.g. https://www.scala-js.org/api/scalajs-library/latest/#scala.scalajs.js.package, does not specify favicon using link tag (MDN). In such case, major browsers tends to request "/favicon.ico" on root directory.
Firefox can render the ico file (https://www.scala-js.org/favicon.ico), but Chrome can not.
Unfortunately, I could not figure out the reason...
Anyway, the re-created ico seems to work fine on Chrome and Firefox.
(I just split ico into several png files and merge them via ImageMagick)
The new ico become bigger (300 KB). I hope website master find it is OK, since the file are delivered via CDN (cloudfrare) so that browsers can cache properly.