Skip to content

Give JSPropertyDef a hash #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gzm0 opened this issue Dec 22, 2022 · 0 comments
Closed

Give JSPropertyDef a hash #4769

gzm0 opened this issue Dec 22, 2022 · 0 comments
Assignees
@gzm0
Labels
optimization Optimization only. Does not affect semantics or correctness.
Milestone
v1.13.0

Comments

@gzm0
Copy link
Contributor

gzm0 commented Dec 22, 2022

Follow-up to #4748 / #4768
@gzm0 gzm0 added the enhancement Feature request (that does not concern language semantics, see "language") label Dec 22, 2022
@gzm0 gzm0 self-assigned this Dec 22, 2022
@gzm0 gzm0 added optimization Optimization only. Does not affect semantics or correctness. and removed enhancement Feature request (that does not concern language semantics, see "language") labels Dec 22, 2022
gzm0 added a commit to gzm0/scala-js that referenced this issue Dec 22, 2022
@gzm0
Fix scala-js#4769: Give JSPropertyDef a hash
71e8fc2
@gzm0 gzm0 closed this as completed in c2bf430 Dec 22, 2022
gzm0 added a commit that referenced this issue Dec 22, 2022
@gzm0
Merge pull request #4770 from gzm0/jsprop-hash
702308e 
Fix #4769: Give JSPropertyDef a hash
@gzm0 gzm0 added this to the v1.13.0 milestone Jan 4, 2023
sjrd added a commit to sjrd/dotty that referenced this issue Apr 25, 2024
@sjrd
Upgrade to Scala.js 1.13.0.
b8a9cda 
Code changes are forward ports of the following refactorings:

* Split members of ClassDef by type
  scala-js/scala-js@ec3f406
* Unify TreeHash and Versioned into a single Version
  scala-js/scala-js@9f5071f
* Fix scala-js/scala-js#4769: Give JSPropertyDef a hash
  scala-js/scala-js@c2bf430
sjrd added a commit to sjrd/dotty that referenced this issue Apr 26, 2024
@sjrd
Upgrade to Scala.js 1.13.0.
06c7f1a 
Code changes are forward ports of the following refactorings:

* Split members of ClassDef by type
  scala-js/scala-js@ec3f406
* Unify TreeHash and Versioned into a single Version
  scala-js/scala-js@9f5071f
* Fix scala-js/scala-js#4769: Give JSPropertyDef a hash
  scala-js/scala-js@c2bf430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
optimization Optimization only. Does not affect semantics or correctness.
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
1 participant
@gzm0