Skip to content

publish bootstrapping sources from library-aux in -sources.jar artefacts #12958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
unkarjedy opened this issue Feb 23, 2024 · 5 comments · Fixed by scala/scala#10714
Closed

publish bootstrapping sources from library-aux in -sources.jar artefacts #12958

unkarjedy opened this issue Feb 23, 2024 · 5 comments · Fixed by scala/scala#10714
Assignees
@lrytz
Labels
build has PR
Milestone
2.13.14

Comments

@unkarjedy
Copy link

This is needed to show documentation of definitions inside those classes inside IDE.
See https://youtrack.jetbrains.com/issue/SCL-22167 (with comments)

The sources are located here:
https://github.com/scala/scala/tree/2.13.x/src/library-aux

It's already done for scala docs—they are published in -javadoc.jar artifacts.
@lrytz lrytz added this to the 2.13.14 milestone Feb 23, 2024
@lrytz lrytz added the build label Feb 23, 2024
@robstoll robstoll mentioned this issue Feb 23, 2024
Closed
@SethTisue
Copy link
Member

@lrytz did we want to try to squeeze this into 2.13.14?

@lrytz
Copy link
Member

lrytz commented Mar 13, 2024

👍

@lrytz lrytz self-assigned this Mar 13, 2024
@lrytz lrytz mentioned this issue Mar 14, 2024
Merged
@unkarjedy
Copy link
Author

BTW, can anyone tell why these source files are special that they are located in a separate library-aux directory?
How e.g. Unit is different?
Also, why do Unit, AnyRef, Int have .class files but Any and Singleton do not?

@lrytz
Copy link
Member

lrytz commented Apr 2, 2024

I guess Int and the others can be represented precisely (enough) in Scala source so that the compiler can build its symbols and types from source. The backend of course intercepts primitives to emit them accordingly.

Trying to do the same with Nothing / Any / ... would need more magic in the compiler, I assume it was easier to create these symbols synthetically (https://github.com/scala/scala/blob/v2.13.13/src/reflect/scala/reflect/internal/Definitions.scala#L337-L354).

@unkarjedy unkarjedy mentioned this issue Apr 2, 2024
Closed
@unkarjedy
Copy link
Author

Similar Scala 3 ticket: scala/scala3#20073

@lrytz lrytz added the has PR label Apr 3, 2024
unkarjedy added a commit to JetBrains/intellij-scala that referenced this issue Apr 25, 2024
@unkarjedy
[synthetic psi] provide a proper navigation element from sources for …
9ed0fd5 
…synthetic elements from scala library #SCL-22167 fixed, #SCL-22350

Should work since Scala 2.13.14
See scala/bug#12958
unkarjedy added a commit to JetBrains/intellij-scala that referenced this issue Apr 26, 2024
@unkarjedy
[synthetic psi] provide a proper navigation element from sources for …
981f992 
…synthetic elements from scala library #SCL-22167 fixed, #SCL-22350

Should work since Scala 2.13.14
See scala/bug#12958
unkarjedy added a commit to JetBrains/intellij-scala that referenced this issue Apr 26, 2024
@unkarjedy
[synthetic psi] provide a proper navigation element from sources for …
8cece08 
…synthetic elements from scala library #SCL-22167 fixed, #SCL-22350

Should work since Scala 2.13.14
See scala/bug#12958


(cherry picked from commit 981f992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrytz lrytz

Labels
build has PR
Projects
None yet
Milestone
2.13.14
Development

Successfully merging a pull request may close this issue.

Include library-aux sources in library sources jar lrytz/scala
3 participants
@lrytz @SethTisue @unkarjedy