rep overrides commit

[scabug]

The rep parser combinator makes the commit parser combinator ineffective, for example this should not parse but does:

import scala.util.parsing.combinator._
object Test extends RegexParsers {
def test = parseAll(rep(commit("a")) ~ "b", "aaab")
}

I believe the problem is Parsers.scala 649-652

  @tailrec def applyp(in0: Input): ParseResult[List[T]] = p0(in0) match {
    case Success(x, rest) => elems += x ; applyp(rest)
    case _                => Success(elems.toList, in0)
  }

should be:

  @tailrec def applyp(in0: Input): ParseResult[List[T]] = p0(in0) match {
    case Success(x, rest) => elems += x ; applyp(rest)
    case e @ Error(_, _)  => e
    case _                => Success(elems.toList, in0)
  }

[scabug]

Imported From: https://issues.scala-lang.org/browse/SI-6067?orig=1
Reporter: George Fraser (george.w.fraser)
Affected Versions: 2.9.0

[scabug]

@adriaanm said:
contributions welcome on github -- unfortunately we don't have the resources to address this right now

[scabug]

@SethTisue said:
The parser combinators library is now community-maintained. Issues with it are now tracked at scala/scala-parser-combinators#61 instead of here in the Scala JIRA.

Interested community members: if you consider this issue significant, feel free to open a new issue for it on GitHub, with links in both directions.