Skip to content

Overriding Future.onSuccess in FutureConvertersImpl #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NthPortal opened this issue Feb 22, 2018 · 1 comment
Closed

Overriding Future.onSuccess in FutureConvertersImpl #99

NthPortal opened this issue Feb 22, 2018 · 1 comment

Comments

@NthPortal
Copy link
Contributor

FutureConvertersImpl.P overrides onSuccess here with a call to super. Is there an important reason for that, or can it be removed?

This comes up because onSuccess is deprecated, and may be removed in 2.13 (see scala/scala#6319).
@NthPortal
Copy link
Contributor Author

If it can be safely removed, #100 removes it.

@NthPortal NthPortal mentioned this issue Feb 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NthPortal