Remove override of Future.onSuccess
#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2018
|
The build failure seems to have nothing to do with the changes from this PR - not sure what to do about that |
|
It looks like it's failing with the same error as the latest build on master, so maybe it's not a problem? |
|
@retronym I'm not familiar with this code. will removing the override harm us on 2.12? is this a case where we will need to have separate |
correct, it's #97 |
retronym
approved these changes
Mar 5, 2018
|
thanks Nth, appreciate your diligence in following through with this in multiple repos |
|
@SethTisue No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future.onSuccessis deprecated and slated for removal. See also scala/scala#6319.Fixes #99