Skip to content

Remove override of Future.onSuccess #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

NthPortal
Copy link
Contributor

@NthPortal NthPortal commented Feb 22, 2018

Future.onSuccess is deprecated and slated for removal. See also scala/scala#6319.

Fixes #99

@NthPortal
Copy link
Contributor Author

The build failure seems to have nothing to do with the changes from this PR - not sure what to do about that

@NthPortal
Copy link
Contributor Author

It looks like it's failing with the same error as the latest build on master, so maybe it's not a problem?

@SethTisue SethTisue requested a review from retronym February 22, 2018 16:44
@SethTisue
Copy link
Member

SethTisue commented Feb 22, 2018

@retronym I'm not familiar with this code. will removing the override harm us on 2.12? is this a case where we will need to have separate src/main/scala-2.12 and src/main/scala-2.13 directories?

@SethTisue
Copy link
Member

It looks like it's failing with the same error as the latest build on master, so maybe it's not a problem?

correct, it's #97

@retronym retronym merged commit 668c31a into scala:master Mar 5, 2018
@NthPortal NthPortal deleted the future-onsuccess branch March 5, 2018 03:24
@SethTisue
Copy link
Member

thanks Nth, appreciate your diligence in following through with this in multiple repos

@NthPortal
Copy link
Contributor Author

@SethTisue No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants