-
Notifications
You must be signed in to change notification settings - Fork 326
2.11.0-M8 announcement #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
created from https://github.com/scala/make-release-notes/tree/v2.11.0-M8, with: ``` sbt -Dfile.encoding=UTF-8 console scala> MakeReleaseNotes.genPR("2.11.0-M7", "2.11.0-M8", "2014/01/28") ``` sanity checked (after `sudo gem install maruku`): `maruku --html 2014-01-28-release-notes-2.11.0-M8.md`
I installed maruku locally to verify the comment at the top didn't break anything |
LGTM. |
So that comment will likely break the site again when we add a new news item. |
Oh, I did not understand correctly the issue the last time, then :-s Sorry, I will remove it. |
I noticed the formatting issue with the comment locally. When i moved it up, it was no longer broken, so i assumed that was enough. |
Something odd happened here: https://github.com/scala/scala-lang/blob/master/_includes/news-feed.html#L55 I'm not certain (I'd have to rollback and recreate the working tree when @sjrd was having issues) but I think that the |
So the last time, the problem moved to the first item in the "recent news" sidebar after a new news item was added, resulting in an open and dangling HTML comment. It seems like an oversight on jekyll's side. I'd have to look into it – maybe a newer version of jekyll would fix it. |
Submitting a follow-up PR to remove the comment and fix other minor issues. |
@sjrd already removed the comment. New idea though, yaml front matter that contains your comments and todos? :/ Might be weird, but def wouldn't break jekyll. |
on the topic of yaml front matter: my editor syntax colors the last |
created from https://github.com/scala/make-release-notes/tree/v2.11.0-M8, with:
sanity checked (after
sudo gem install maruku
):maruku --html 2014-01-28-release-notes-2.11.0-M8.md
ready to be merged -- review by @sjrd or @heathermiller