Skip to content

Mute console output in test #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

ashawley
Copy link
Member

A typical running of the test suite results in the following transcript:

Testing scala-xml version 1.0.6-SNAPSHOT.
:9:19: '/' expected instead of ''                  ^
:9:19: name expected, but char '' cannot start a name                  ^
[info] Passed: Total 106, Failed 0, Errors 0, Passed 106
[success] Total time: 19 s, completed Sep 14, 2015 2:19:49 PM

The second and third lines aren't useful unless you were debugging the particular test, scala.xml.pull.XMLEventReaderTest.missingTagTest. The patch below simply quiets the console output by overriding the reportError method of scala.xml.pull.XMLEventReader to do nothing. Here's the new transcript:

Testing scala-xml version 1.0.6-SNAPSHOT.
[info] Passed: Total 106, Failed 0, Errors 0, Passed 106
[success] Total time: 18 s, completed Sep 14, 2015 2:29:14 PM

Presumably, there is a way to capture the output and assert what it is, but I didn't look in to it.

@ashawley
Copy link
Member Author

Turns out the changes I made here are already made in the pull request #44 by @som-snytt. That PR needs to be rebased to get the latest changes from master, but if it does get merged, my PR here can just be closed.

@ashawley
Copy link
Member Author

I opened #93 that minimizes the changes to fix #35 and #44, so this pull request is relevant again.

@ashawley ashawley force-pushed the mute-console-output-in-test branch from f1d8869 to 8f8b023 Compare April 22, 2016 19:59
@ashawley ashawley closed this Jun 12, 2016
@ashawley ashawley force-pushed the mute-console-output-in-test branch from 8f8b023 to 55008bd Compare June 12, 2016 22:32
@ashawley
Copy link
Member Author

This was fixed when #99 was merged.

@ashawley ashawley deleted the mute-console-output-in-test branch September 15, 2016 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant