Fix primitive operations on Long with Float #7435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA now. |
|
Would be good to add a test case from the original issue to make sure it's fixed and stays fixed. |
|
@densh good idea, I will add it. |
|
Should this be backported to scala 2.12.x too? |
|
@hepin1989 Since this is a bug, so backport will be good. |
adriaanm
approved these changes
Nov 19, 2018
|
gah, I meant to ask for test coverage, but I hit "merge" instead. oh well @satansk if you submit a 2.12.x backport that also includes test coverage, it will be merged forward onto 2.13.x as well |
GreenRecycleBin
added a commit
to GreenRecycleBin/scala
that referenced
this pull request
Sep 5, 2021
The result must be BTypes.FLOAT instead of BTypes.DOUBLE. This implementation incorporates the suggestion at scala#7435 (review).
GreenRecycleBin
added a commit
to GreenRecycleBin/scala
that referenced
this pull request
Sep 5, 2021
The result must be BTypes.FLOAT instead of BTypes.DOUBLE. This implementation incorporates the suggestion at scala#7435 (review). It also adds unit tests for BTypes.LONG receivers of this method.
GreenRecycleBin
added a commit
to GreenRecycleBin/scala
that referenced
this pull request
Sep 5, 2021
The result must be BTypes.FLOAT instead of BTypes.DOUBLE. This implementation incorporates the suggestion at scala#7435 (review). It also adds unit tests for BTypes.LONG receivers of this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scala/bug#11253, according to @sjrd 's comments, modify
maxValueTypeshould fix the problem.