Merge pull request #9962 from prolativ/fix-long-and-float-max-value-type

Fix #5441: Primitive operations on Long with Float argument have different semantics from Java

Author: smarter

compiler/src/dotty/tools/backend/jvm/BTypes.scala

@@ -290,9 +290,12 @@ abstract class BTypes {
           }
 
         case LONG =>
-          if (other.isIntegralType)  LONG
-          else if (other.isRealType) DOUBLE
-          else                       uncomparable
+          other match {
+            case INT | BYTE | LONG | CHAR | SHORT => LONG
+            case DOUBLE                           => DOUBLE
+            case FLOAT                            => FLOAT
+            case _                                => uncomparable
+          }
 
         case FLOAT =>
           if (other == DOUBLE)          DOUBLE

tests/run/i5441.check

@@ -0,0 +1,3 @@
+1.164309
+1.164309
+2.3242621

tests/run/i5441.scala

@@ -0,0 +1,8 @@
+object Test {
+  def main(args: Array[String]): Unit  =
+    def a(): Float = java.lang.Float.intBitsToFloat(1079290514)
+    def b(): Long = 1412906027847L
+    println(b() % a())
+    println((b().toFloat % a().toFloat).toFloat)
+    println((b().toDouble % a().toDouble).toFloat)
+}