Fix #5441: Primitive operations on Long with Float argument have different semantics from Java

[prolativ]

No description provided.

[dottybot]

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

1. Separate subject from body with a blank line
2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
3. Limit the subject line to 72 characters
4. Capitalize the subject line
5. Do not end the subject line with a period
6. Use the imperative mood in the subject line ("Add" instead of "Added")
7. Wrap the body at 80 characters
8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

[smarter]

It looks like the corresponding patch in scalac is slightly different: https://github.com/scala/scala/pull/7435/files, any reason to do things differently? If not it'd be good to do the same thing they do to keep the diff between the two backent as small as possible.

[prolativ]

@smarter there were a few comments to the original PR that were not taken into account because the PR got merged too early by accident so I introduced the requested changes here

[smarter]

I see, but if the code is equivalent I would prefer going with the scalac version, just so that when we diff the two we don't get confused about why there's a difference here (alternatively we could update both the dotty and scalac and backend at the same time, but it doesn't seem worth it if the code is equivalent anyway).

[prolativ]

OK, using the implementation from scala repo

[smarter]

Thanks!