-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Top-level private definitions are not reported as unused #20520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is as expected, because the example is
and if it's in a named package, then it is private to the package. The members can be accessed under separate compilation. Possibly, the expectation was that Also members that are unimplemented with Closing here as not a bug, but there is a test for status quo. |
…20894) This PR changes the `CheckUnused` phase to rely on the `MiniPhase` API (instead of custom traversal). That improves fidelity to `Context` (instead of approximate scoping). The phase should work seamlessly with subsequent linting phases (currently, `CheckShadowed`). It is a goal of the PR to eliminate false reports. It is also a goal not to regress previous work on efficiency. A remaining limitation of the current approach is that contexts don't provide a nesting level. Practically, this means that for a wildcard import nested below a higher precedence named import, the wildcard is deemed "unused". (A more general tool for "managing" or "formatting" imports could do more to pick a preferred scope.) This PR adds `-Wunused:patvars`, as forward-ported from Scala 2: it relies on attachments for some details about desugaring, but otherwise uses positions (where only the original patvar has a non-synthetic position). As in Scala 2, it does not warn about patvars with the "canonical" name of a case class element (this is complicated by type tests and the quotes API); other exclusions are to be ported, such as "name derived from the match selector". Support is added for `-Wconf:origin=full.path.selector`, as in Scala 2. That allows, for example: ``` -Wconf:origin=scala.util.chaining.given:s ``` to exclude certain blessed imports from warnings, or to work around false positives (should they arise). Support is added to `-rewrite` unused imports. There are no options to "format"; instead, textual deletions preserve existing formatting, except that blank lines are removed and braces removed when there is only one selector. Notable fixes are to support `compiletime` and `inline`; there are more fixes to pursue in this area. Fixes #19657 Fixes #20520 Fixes #19998 Fixes #18313 Fixes #17371 Fixes #18708 Fixes #21917 Fixes #21420 Fixes #20951 Fixes #19252 Fixes #18289 Fixes #17667 Fixes #17252 Fixes #21807 Fixes #17753 Fixes #17318 Fixes #18564 Fixes #22376 Fixes #21525
Compiler version
3.5.1-RC1-bin-20240602-c6fbe6f-NIGHTLY
Minimized code
Top level private definitions are not reported as unused.
Output
Expectation
The text was updated successfully, but these errors were encountered: