Skip to content

Add regression test for i11967 #11975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

Add regression test for i11967 #11975

merged 1 commit into from
May 10, 2021

Conversation

noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Apr 3, 2021 •
edited
Loading

From #11967

@noti0na1 noti0na1 linked an issue Apr 3, 2021 that may be closed by this pull request
Null checks with pattern matching are not reflected to the return type with -Yexplicit-nulls #11967
Closed
@noti0na1 noti0na1 requested a review from smarter April 3, 2021 07:28
@noti0na1 noti0na1 enabled auto-merge April 3, 2021 08:27
lolgab
lolgab suggested changes Apr 3, 2021
View reviewed changes
@odersky
Copy link
Contributor

odersky commented Apr 27, 2021

I think it would be good keep the issue open and turn this into only pos tests instead.

@noti0na1 noti0na1 removed a link to an issue Apr 27, 2021
Null checks with pattern matching are not reflected to the return type with -Yexplicit-nulls #11967
Closed
@noti0na1
Copy link
Member Author

@odersky The neg test is removed, and the issue is unlinked.

liufengyun
liufengyun approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noti0na1 noti0na1 merged commit 6a41a2b into scala:master May 10, 2021
@noti0na1 noti0na1 deleted the i11967 branch May 10, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky left review comments

@lolgab lolgab lolgab requested changes

@liufengyun liufengyun liufengyun approved these changes

@smarter smarter Awaiting requested review from smarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noti0na1 @odersky @liufengyun @lolgab