support intersection types in mirrorCompanionRef #15192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
force-pushed
the
fix-15190
branch
2 times, most recently
from
ef77817 to
085b2ab
Compare
bishabosha
force-pushed
the
fix-15190
branch
3 times, most recently
from
330e1b2 to
6842110
Compare
remove case: OrType is no longer supported
sjrd
requested changes
May 30, 2022
sjrd
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
MirrorSource- i.e. an abstract representation of what is used to create the mirror. This means only one traversal of types compared to usingwhyNotAcceptableType. It also is extensible, i.e. allowing us to add new kinds of types supporting mirrors, such as generic tuple types.This also fixes an uncaught bug where we could summon a mirror for
::[Int] & Some[Int], which would only fail at runtimecloses #15190