Skip to content

Add regression tests #15339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2022
Merged

Add regression tests #15339

merged 1 commit into from
Jun 6, 2022

Conversation

nicolasstucki
Copy link
Contributor

with prototype of places macro

@nicolasstucki nicolasstucki requested a review from abgruszecki May 31, 2022 12:01
@nicolasstucki nicolasstucki marked this pull request as ready for review May 31, 2022 12:01
@nicolasstucki nicolasstucki enabled auto-merge June 2, 2022 10:50
@nicolasstucki nicolasstucki added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Jun 2, 2022
@nicolasstucki nicolasstucki force-pushed the add-place-regression-test branch from e1afa10 to 80bb1df Compare June 2, 2022 16:58
@nicolasstucki
Add regression tests
a4bab18 
with prototype of places macro
@nicolasstucki nicolasstucki force-pushed the add-place-regression-test branch from 80bb1df to a4bab18 Compare June 2, 2022 17:01
abgruszecki
abgruszecki approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me so far! This implementation still needs to consider fields, including the ones defined with def x / def x_=, if I understand it correctly.

@nicolasstucki nicolasstucki merged commit e71fe80 into scala:main Jun 6, 2022
@nicolasstucki nicolasstucki deleted the add-place-regression-test branch June 6, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgruszecki abgruszecki abgruszecki approved these changes

Assignees

@abgruszecki abgruszecki

Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @abgruszecki