Fix #15405: Dealias Or type constituents when finding its dominator #15416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
requested changes
Jun 10, 2022
There was a problem hiding this comment.
Normally, baseClasses should already do dealiasing, but it seems in the case of AppliedType they did not. Can you try the following change to baseClasses in Types.scala, line 597?
Change
tp.underlying.baseClassesto
tp.superType.baseClassesIf that works I would think it's a better fix than the change in TypeOps.
|
@anatoliykmetyuk Any progress on this? |
anatoliykmetyuk
force-pushed
the
fix-15405
branch
from
1edc413 to
16b8e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue,
v: Intis boxed toRichInt. This is because the typer can't find>inInt | Validated[Int]and attempts an implicit conversion. This is in turn because when looking up members of a union type, we do thejoinoperation on that union type, which attempts to simplify it by reducing it to the intersection of the base classes of its constituents.It seems that this intersection algorithm, while operating on dealiased constituents, does not dealias them at a certain point, thus judging that the intersection of base types of
IntandValidated[Int]isAny. This PR adds such a dealias.Using
Fooinstead ofIntin tests to remove implicit conversions out of the equation; without the PR's change the test fails.