Skip to content

[Unfinished Spree PR] Fix i12460 #17321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Sporarum
Copy link
Contributor

@Sporarum Sporarum commented Apr 20, 2023

Fixes #12460.

@Sporarum Sporarum added the Spree Suitable for a future Spree label Apr 20, 2023
@nicolasstucki nicolasstucki self-assigned this Jul 13, 2023
@nicolasstucki
Copy link
Contributor

Not sure what is the status of this WIP.

@Sporarum Sporarum assigned mbovel and unassigned Sporarum Oct 30, 2023
@mbovel mbovel removed the Spree Suitable for a future Spree label Jan 14, 2024
@KacperFKorban
Copy link
Member

is this superseded by #22492?
I see that one of the tests checks something about by-name parameters.

@Sporarum
Copy link
Contributor Author

@KacperFKorban I asked about it on the other PR, and on the Scala user forum (here)

@som-snytt
Copy link
Contributor

som-snytt commented Feb 18, 2025

It was my intention to supersede this PR at #22492 (where there is a question about what behavior is desired).

I was looking at the back of the PR queue for things to review or help with.

@Gedochao
Copy link
Contributor

@Sporarum @KacperFKorban @som-snytt can this be closed?
It seems to me #12460 is completed after #22492 got merged.
Still not clear to me if this PR was superseded (and it didn't have any new input for 2 years, so perhaps we should have closed it anyway)

@KacperFKorban
Copy link
Member

#22492 fixes the original issue, so the question is: do we also want to warn for by-name receivers?

I'll close this PR for now. @Sporarum if you want to revisit the by-name receiver warning, you can re-open. (Though it will probably be better, to start with an issue/discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forbid default values for extension parameters
6 participants