Add enum type param support in sourceSymbol #18603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rochala should we rebase and merge? The PR looks ok. |
tgodzik
force-pushed
the
enum-type-param-source-symbol
branch
2 times, most recently
from
898a040 to
6c3d7cd
Compare
tgodzik
force-pushed
the
enum-type-param-source-symbol
branch
from
6c3d7cd to
62e3af5
Compare
|
Ok, turns out this needed a bit more work, but should be ok. @rochala can you double check once you are available? |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18541
sourceSymbolshould point to the symbol present in source code including enum type params.The need of such support is that enums are desugared in such a way that enum class type parameters are copied to enum case class. As this is desugar, the copied symbols are not present in source code, thus
sourceSymbolshould point to enum class type parameter.