Refactor some tuple methods #19032
Merged
Refactor some tuple methods #19032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move from Definitions to TypeUtils - Unify TypeUtils.tupleElementTypes and Definitions.tupleTypes. They do the same thing. I'd like to move more things out of Definitions and into TypeUtils and SymUtils. Then I'd like to move these files to the core package, and make their operations accessible automatically by having the companion objects of Types and Symbols inherit from them. This is a first step into that direction.
= Move to core package. It was for historical reasons in transform because it was originally intended as a collection of type operations that were were useful in transform phases. But it's now used from everywhere. - Make a base class of Types, so that it does not need to be imported explicitly.
odersky
force-pushed
the
refactor-utils
branch
from
78400c9 to
64bbe68
Compare
- Move to core package. It was for historical reasons in transform because it was originally intended as a collection of type operations that were were useful in transform phases. But it's now used from everywhere. - Make a base class of Types, so that it does not need to be imported explicitly. Also: move isDerivedValueClass to SymUtils
odersky
force-pushed
the
refactor-utils
branch
from
64bbe68 to
125321e
Compare
odersky
added
the
backport:nominated
|
@Kordyjan This is a fairly large refactoring to make functionality more discoverable with less boilerplate in the future. I think it would be good to backport this to LTS so that we don't get too much of a divergence between the two versions. |
nicolasstucki
approved these changes
Nov 24, 2023
This was referenced Jun 24, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jun 26, 2024
Backports #19032 to the LTS branch. PR submitted by the release tooling. [skip ci]
WojciechMazur
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to move more things out of Definitions and into TypeUtils and SymUtils. Then I'd like to move these files to the core package, and make their operations accessible automatically by having the companion objects of Types and Symbols inherit from them. This is a first step into that direction.