Skip to content

Backport "Allow eta-expansion of inline defs" to LTS #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

Backport "Allow eta-expansion of inline defs" to LTS #19124

merged 1 commit into from
Dec 8, 2023

Conversation

Kordyjan
Copy link
Contributor

@Kordyjan Kordyjan commented Dec 1, 2023

Backports #18249 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@smarter @Kordyjan
Allow eta-expansion of inline defs
690a6aa 
The fact that this wasn't allowed before seems to be a bug and not an
intentional restriction: the check was originally introduced in
a019a4e for "typelevel methods" which are only
vaguely related to today's inline methods.

[Cherry-picked a7bae7a]
Base automatically changed from lts-18236 to release-3.3.2 December 8, 2023 15:20
@Kordyjan
Copy link
Contributor Author

Kordyjan commented Dec 8, 2023

No regressions detected in the community build up to lts-16941.

Reference

@Kordyjan Kordyjan merged commit fd89fc8 into release-3.3.2 Dec 8, 2023
@Kordyjan Kordyjan deleted the lts-18249 branch December 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kordyjan @smarter