Code

Make CheckUnused not slow.#20321

Code

Merged

sjrd merged 10 commits intoscala:mainscala/scala3:mainfrom

dotty-staging:make-check-unused-not-slowdotty-staging/dotty:make-check-unused-not-slowCopy head branch name to clipboard

May 7, 2024

Commits

Commits on May 6, 2024

• Make `unusedDataApply` inline so that no closure is allocated.

  Show description for 69664f7
  sjrd

  committed
  69664f7

  Copy full SHA for 69664f7

• Do not use `LazyList` in `CheckUnused`.

  Show description for 0bd4b15
  sjrd

  committed
  0bd4b15

  Copy full SHA for 0bd4b15

• Do not mangle names only to test whether it starts with a given string.

  sjrd

  committed
  6d79caa

  Copy full SHA for 6d79caa

• Remove dead code `newCtx` in `CheckUnused`.

  sjrd

  committed
  3188177

  Copy full SHA for 3188177

• Do not use Sets of Trees in `CheckUnused`.

  Show description for a55ee4d
  sjrd

  committed
  a55ee4d

  Copy full SHA for a55ee4d

• Remove a useless sort and otherwise sort by offset, not line.

  Show description for 701d69f
  sjrd

  committed
  701d69f

  Copy full SHA for 701d69f

• Refactor unused imports to try and make sense of it.

  sjrd

  committed
  803dff7

  Copy full SHA for 803dff7

• Fix some indentation.

  sjrd

  committed
  0c1f090

  Copy full SHA for 0c1f090

Commits on May 7, 2024

• Simplify the logic for checking unused imports.

  Show description for 975df4a
  sjrd

  committed
  975df4a

  Copy full SHA for 975df4a

• Move the isAccessible test up to registerSym, instead of isInImport.

  Show description for 8553bfc
  sjrd

  committed
  8553bfc

  Copy full SHA for 8553bfc