Skip to content

Bump scala-cli to 1.4.0 #20859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Bump scala-cli to 1.4.0 #20859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ object Build {
val mimaPreviousLTSDottyVersion = "3.3.0"

/** Version of Scala CLI to download */
val scalaCliLauncherVersion = "1.3.2"
val scalaCliLauncherVersion = "1.4.0"
/** Version of Scala CLI to download (on Windows - last known validated version) */
val scalaCliLauncherVersionWindows = "1.3.2"
val scalaCliLauncherVersionWindows = "1.4.0"
Copy link
Member Author

@hamzaremmal hamzaremmal Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is brand new, we should come up with the procedure when updating scala-cli. 1.4.0 was just released yesterday and is not validated by windows... but it is a change in minor and it is weird to have different scala-cli versions for the same scala release...

Copy link
Member

@bishabosha bishabosha Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this windows cli version is that we don't update it, the real Scala-cli version is passed as a command line flag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but it weird to have different minor versions across different platforms for the same release of scala

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, we should keep it until 1.4.0 is at least 30 days old.
However, might still be tempting to get this in to have the fix from VirtusLab/scala-cli#2957...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the decision was made

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know.
Let's hold our horses until we decide on a timeline for this.

/** Version of Coursier to download for initializing the local maven repo of Scala command */
val coursierJarVersion = "2.1.10"

Expand Down
Loading