feat: show inferred type on holes in hover [skip ci] #21423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think making it work even for some cases would be cool. Great idea! |
|
@kasiaMarek do you want to get back to this? |
Yeah, I don't think there is anything really to be done here. I just need to run the CI. |
kasiaMarek
force-pushed
the
show-type-on-holes
branch
from
2db9b7f to
99b1060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruit after: #21390.
It seems useful to see the inferred "expected" type on holes, so this PR adds them to be visible on hover.
This won't be perfect, as we can't always infer the expected type as we'd like to (see:
InferExpectedTypeSuite#flatmap, so I'm sure we want to introduce that at all.Side note: Probably we should write something different than
Expression type:in hover here.cc: @tgodzik