Skip to content

Respect [skip-ci] comments in launchers and spec tests #21472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Respect [skip-ci] comments in launchers and spec tests #21472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42ca655
Respect `[skip-ci]` comments in lanuchers and spec tests
WojciechMazur Aug 28, 2024
3bd4a7a
Exclude build-sdk-package from when skip ci annotation is present
WojciechMazur Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,9 +1013,15 @@ jobs:
uses: ./.github/workflows/build-msi.yml
if : github.event_name == 'pull_request' && contains(github.event.pull_request.body, '[test_msi]')
# TODO: ADD A JOB THAT DEPENDS ON THIS TO TEST THE MSI

build-sdk-package:
uses: ./.github/workflows/build-sdk.yml
if:
(github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]')) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3') ||
(github.event_name == 'schedule' && github.repository == 'scala/scala3') ||
github.event_name == 'push' ||
github.event_name == 'merge_group'
with:
java-version: 8

Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/launchers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ jobs:
linux-x86_64:
name: Deploy and Test on Linux x64 architecture
runs-on: ubuntu-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand Down Expand Up @@ -43,6 +45,8 @@ jobs:
mac-x86_64:
name: Deploy and Test on Mac x64 architecture
runs-on: macos-13
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand All @@ -62,6 +66,8 @@ jobs:
mac-aarch64:
name: Deploy and Test on Mac ARM64 architecture
runs-on: macos-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand All @@ -81,6 +87,8 @@ jobs:
win-x86_64:
name: Deploy and Test on Windows x64 architecture
runs-on: windows-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ env:
jobs:
specification:
runs-on: ubuntu-latest
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]')) ||
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3') ||
github.event_name == 'push' ||
github.event_name == 'merge_group'
defaults:
run:
working-directory: ./docs/_spec
Expand Down