Skip to content

Backport from Metals #22426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Backport from Metals #22426

merged 8 commits into from
Jan 22, 2025

Conversation

kasiaMarek
Copy link
Member

@kasiaMarek kasiaMarek requested a review from tgodzik January 22, 2025 12:30
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik
Copy link
Contributor

tgodzik commented Jan 22, 2025

It seems one test is still failing though :/

@kasiaMarek
Copy link
Member Author

kasiaMarek commented Jan 22, 2025

It seems one test is still failing though :/

Seems to be some flaky worksheet test timeout. Let's see if re-run helps

@tgodzik
Copy link
Contributor

tgodzik commented Jan 22, 2025

It seems one test is still failing though :/

Seems to be some flaky worksheet test timeout. Let's see if re-run helps

Ach, if this happens more we might consider removing the module. Or maybe we should remove it anyway since we have all the metals tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants