-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Backport from Metals #22426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport from Metals #22426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It seems one test is still failing though :/ |
Seems to be some flaky worksheet test timeout. Let's see if re-run helps |
Ach, if this happens more we might consider removing the module. Or maybe we should remove it anyway since we have all the metals tests now. |
scalameta/metals#6881
scalameta/metals#6929
scalameta/metals#6986
scalameta/metals#7000
scalameta/metals#7001
scalameta/metals#7096