Fix global init checking crash when using a value defined in by-name closure #22625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-ata
force-pushed
the
safe-init-global-envs
branch
from
c10505f to
37e7e2a
Compare
olhotak
approved these changes
Feb 19, 2025
liufengyun
approved these changes
Feb 19, 2025
| None | ||
| case _ => | ||
| None | ||
| } |
There was a problem hiding this comment.
I was thinking whether we can simplify resolveEnvByValue to just return the value for the local variable. We'll probably need two methods, one for mutable, one for immutable. But the logic would be simpler and it'll be easier to handle the TODOs.
That leaves us with the case for lazy local variables, for that one, we can use resolveEnvByOwner.
If it makes sense, it can be experimented in another PR.
|
In order to avoid breaking nightly build, I added |
|
@liufengyun @q-ata @olhotak is this ready to be merged? |
|
The last commit needs to be remove and then it's ready to go in. |
q-ata
force-pushed
the
safe-init-global-envs
branch
from
42d0dfd to
f3c4751
Compare
liufengyun
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that would occur when analyzing a by-name closure that reads a local value.
This was because the value would have an incorrect
enclosingMethodfield due to the analysis running before by-names are transformed by the elimByName pass.[test_scala2_library_tasty]