@publicInBinary has now effect on secondary constructors
#22630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Feb 20, 2025
| @@ -102,6 +105,8 @@ class ExpandPrivate extends MiniPhase with IdentityDenotTransformer { thisPhase | |||
| override def transformDefDef(tree: DefDef)(using Context): DefDef = { | |||
| val sym = tree.symbol | |||
| tree.rhs match { | |||
| case _ if sym.isConstructor && sym.hasPublicInBinary => | |||
There was a problem hiding this comment.
This is a weird way to write an if condition, but avoids another level of indentation with an if-else expression.
There was a problem hiding this comment.
SIP-39 - Uncluttering Abuse of Match
hamzaremmal
changed the title
@publicInBinary has effect on secondary constructors@publicInBinary has now effect on secondary constructors
hamzaremmal
force-pushed
the
i22497
branch
2 times, most recently
from
6d84032 to
b99156e
Compare
sjrd
requested changes
Feb 21, 2025
sjrd
approved these changes
Feb 21, 2025
Gedochao
added
stat:needs preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22498