Check only stable qual for import prefix #22633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Is it intended that this file has no indentation whatsoever?
There was a problem hiding this comment.
I ingested the generated file as-is. I did try a version limited to 3 type params, but that doesn't show much.
Probably I will drop the large test source, but is there anything useful to add as a test? A "performance" test could generate it, etc. Or maybe it's no big deal to leave as it is for now. It's a few kb that will never leave the repo.
som-snytt
force-pushed
the
issue/22629-unused-performance
branch
from
b95bb20 to
77af110
Compare
|
Minimization doesn't use the I was prepared to generate the large source in |
sjrd
approved these changes
Feb 24, 2025
som-snytt
force-pushed
the
issue/22629-unused-performance
branch
from
77af110 to
5429dfa
Compare
sjrd
added a commit
that referenced
this pull request
Mar 4, 2025
Follow-up to #22633 which restricts import prefixes to stable prefixes. This commit further excludes `this` and `super`; these are arbitrary synthetic expressions introduced by macros. Noticed at #22690 (comment) which now warns correctly. Requires a unit test. Fixes #22690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection from a tree with synthetic span looks like a rewrite from imported symbol, but only check that if the qualifier is stable.
In the example, it was an implicit class (
EitherOps), which in turn induced many costly, unnecessary type comparisons.The test sample code is not yet minimized, so it is just for demonstration purposes. Since the symptom is a performance regression, there is no trivial test that demonstrates it was doing something wrong, as well as doing it slowly.
Locally,
-verbosereportsFixes #22629