Skip to content

Handle Typeable #22663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 25, 2025

Fixes #22642

Turn code comments into actual code.

@som-snytt som-snytt force-pushed the issue/22642-unused-select-crash branch from ea76784 to 5140cd7 Compare February 25, 2025 02:34
@som-snytt som-snytt marked this pull request as ready for review February 26, 2025 18:17
@Gedochao Gedochao requested a review from noti0na1 February 27, 2025 09:39
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -830,6 +830,8 @@ class Definitions {

@tu lazy val ReflectSelectableTypeRef: TypeRef = requiredClassRef("scala.reflect.Selectable")

@tu lazy val TypeablePackageClass: Symbol = requiredPackage("scala.reflect.Typeable$package").moduleClass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep a TypeablePackageClass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not.

@som-snytt som-snytt force-pushed the issue/22642-unused-select-crash branch from 5140cd7 to b52b057 Compare February 27, 2025 15:23
@noti0na1 noti0na1 merged commit e592b37 into scala:main Feb 28, 2025
29 checks passed
@som-snytt som-snytt deleted the issue/22642-unused-select-crash branch February 28, 2025 16:19
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Wunused against lila
3 participants