Rename on import is never wildcard #22712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
port/issue/22692-rename-is-never-wildcard
branch
from
162a3f0 to
f31a069
Compare
|
I assumed the rename tests in https://github.com/scala/scala3/blob/main/tests/warn/i15503a.scala cover it, but it doesn't hurt to add the new test code. The existing test is augmented and also behaves differently from the original commit. This commit does not change correctness, and I did not instrument the internal behavior for testing. |
sjrd
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port #22710
For a symbol referenced by an alternate name, there must be renaming selector in scope (because the code typechecks), and that import is necessarily higher precedence than a wildcard and will be preferred.
However, it's
wrongunnecessary to track the wildcard as a candidate solution. The laborious conversion to terms is necessary because thenamedoes not remember whether it was a rename (i.e., due to anOriginalNameattachment). Note that if the name test is more expensive than the current cost, then this commit would be less efficient; a mantra of the refactor was to defer the cost of executing a test.