Skip to content

chore: add regression test for #22567 #22765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Mar 10, 2025

Closes #22567

Most likely closing #22571 too

The last run of Open CB confirmed that it closes #22571 too.

@hamzaremmal hamzaremmal self-assigned this Mar 10, 2025
@som-snytt
Copy link
Contributor

som-snytt commented Mar 10, 2025

The pos test doesn't have -Werror; I think vulpix does not check for "no output" if check file is missing? (Too late in the day for me to verify that.)

I commented on the ticket that my PR that just got merged is the fix (makes the message go away). That PR has something to with how implicit args are conjured in an application.

That test was tests/neg/i22439.scala, I haven't compared yet. Edit: that test doesn't include defaults (for some reason).

There is a default in tests/neg/i19594.scala

@hamzaremmal hamzaremmal requested a review from som-snytt March 11, 2025 15:57
@hamzaremmal hamzaremmal marked this pull request as ready for review March 11, 2025 15:57
@hamzaremmal hamzaremmal enabled auto-merge March 11, 2025 15:57
@som-snytt
Copy link
Contributor

@hamzaremmal I noticed that my other PR was for your other ticket about implicit args in January, so thanks for that. I don't remember exactly why it caught my attention (probably I thought it would be an easy fix), but I remember it was interesting and I wouldn't have tried it without your ticket.

@hamzaremmal hamzaremmal merged commit ff8451a into scala:main Mar 11, 2025
29 checks passed
@hamzaremmal hamzaremmal deleted the i22571 branch March 11, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants