add selection ranges for more names #23257
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zielinsky
force-pushed
the
selection-ranges
branch
from
fd23488 to
15b7b5b
Compare
tgodzik
requested changes
May 27, 2025
| case vdef @ ValDef(_, tpt, _) => | ||
| maybeToSelectionRange(vdef.namePos) | ||
| ++ maybeToSelectionRange(tpt.sourcePos) | ||
| ++ maybeToSelectionRange(vdef.rhs.sourcePos) |
There was a problem hiding this comment.
Why do we need rhs? Wouldn't that already be added by the tree inside RHS? Same for tpt. untpdPath should give us all tree nodes on the way to the current position.
| ++ maybeToSelectionRange(vdef.rhs.sourcePos) | ||
| case tdef @ TypeDef(_, rhs) => | ||
| maybeToSelectionRange(tdef.namePos) | ||
| ++ maybeToSelectionRange(rhs.sourcePos) |
There was a problem hiding this comment.
Same here, is there a test case this fixes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add selection ranges for more names.
Porting scalameta/metals#7446