Skip to content

Fix #2856 Drop special treatment of packages in findRef #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2017
Merged

Fix #2856 Drop special treatment of packages in findRef #2860

merged 2 commits into from
Jul 13, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 12, 2017

This aligns behavior with scalac.

odersky added 2 commits July 12, 2017 19:14
@odersky
Fix scala#2856 Drop special treatment of packages in findRef
a92652c 
This aligns behavior with scalac.
@odersky
Fix scala#2856: Prioritize root package members over root imports
f50bf57 
The fix is more complex than I would like (see comment in source code).
If someone can reproduce the error locally without this commit and rack it down
this would help enormously.
@odersky
Copy link
Contributor Author

odersky commented Jul 13, 2017

The PR is much nicer with only the fist commit. Unfortunately CI dies with a cyclic reference error in compileStdLib. If I compile locally even with the exact sequence of files as given it succeeds. I don't have the time to track this down so for the moment we have to live with an unnecessary complication. If someone feels courageous enough to follow up on this, please do!

@odersky odersky requested review from smarter and olafurpg July 13, 2017 12:18
olafurpg added a commit to dotty-staging/ScalaPB that referenced this pull request Jul 13, 2017
@olafurpg
Fully qualify references to the io root package.
c0cc178 
Revert this commit once scala/scala3#2860 is
merged.
olafurpg
olafurpg approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no rush to get this fixed from my side. I've added a note in the ScalaPB community fork to revert the workaround once this gets merged.

I don't have much context to judge the quality of the the fix, but the pos test looks good 👍

@smarter
Copy link
Member

smarter commented Jul 13, 2017

Unfortunately CI dies with a cyclic reference error in compileStdLib. If I compile locally even with the exact sequence of files as given it succeeds.

Same here, and I tried rerunning the same commit on the CI and couldn't get it to fail either. This is pretty bad, but it also means that your commit might be completely unrelated to the problem.

@odersky
Copy link
Contributor Author

odersky commented Jul 13, 2017

Let me go back a commit and see if the problem reappears.

@smarter
Copy link
Member

smarter commented Jul 13, 2017

Hmm, it did reappear indeed, so I'm very confused by the fact that the same commit succeeded the CI on http://dotty-ci.epfl.ch/smarter/dotty/1.

smarter
smarter approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway, but something to come back to.

@odersky
Copy link
Contributor Author

odersky commented Jul 13, 2017

I undid the undo. Mystery remains.

@odersky odersky merged commit 5ba8ea3 into scala:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @smarter @olafurpg