Skip to content

Add scala-parser-combinators to community build #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add scala-parser-combinators to community build #8604

merged 1 commit into from
Mar 30, 2020

Conversation

Philippus
Copy link
Member

No description provided.

dottybot
dottybot reviewed Mar 25, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@bishabosha
Copy link
Member

Hello, thank you for opening this, would you be able to rebase c067313 on master instead of merging it into your branch?

@anatoliykmetyuk anatoliykmetyuk self-assigned this Mar 28, 2020
@anatoliykmetyuk
Copy link
Contributor

Hi @Philippus, thanks for adding it. All of the Dotty community projects live as forks under dotty-staging organization. I have created such a fork for you: https://github.com/dotty-staging/scala-parser-combinators – can you point the submodule to this fork instead?

@Philippus
Copy link
Member Author

Ah ok, thank you for creating the fork. I think I repointed the submodule now.

@anatoliykmetyuk anatoliykmetyuk merged commit f3518f1 into scala:master Mar 30, 2020
@Philippus Philippus deleted the add-scala-parser-combinators branch March 30, 2020 13:11
@Philippus Philippus mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@anatoliykmetyuk anatoliykmetyuk anatoliykmetyuk approved these changes

Assignees

@Philippus Philippus

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Philippus @bishabosha @anatoliykmetyuk @dottybot