add basic windows job settings #9934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
windows-ci
branch
3 times, most recently
from
2bb4e49 to
c44f719
Compare
liufengyun
force-pushed
the
windows-ci
branch
2 times, most recently
from
e7efd94 to
c8b5896
Compare
liufengyun
force-pushed
the
windows-ci
branch
16 times, most recently
from
52217a5 to
bf27928
Compare
Currently, Github actions only support Linux containers.
Instead of create project/scripts/sbt.bat, we update .jvmopts. -J-X options are not supported on windows: sbt/sbt#5179
liufengyun
force-pushed
the
windows-ci
branch
3 times, most recently
from
eb22fe8 to
12ec724
Compare
liufengyun
force-pushed
the
windows-ci
branch
3 times, most recently
from
794129d to
6191212
Compare
anatoliykmetyuk
approved these changes
Oct 9, 2020
sjrd
reviewed
Oct 9, 2020
|
|
||
| # - name: Scala.js Test | ||
| # run: sbt ";sjsJUnitTests/test" | ||
| # shell: cmd |
There was a problem hiding this comment.
It causes a failure: https://github.com/lampepfl/dotty/runs/1225047885?check_suite_focus=true
Do you see clue from the message?
There was a problem hiding this comment.
Yeah ^^
Caused by: java.io.IOException: Cannot run program "node": CreateProcess error=2, The system cannot find the file specified
We need to install Node.js ;)
There was a problem hiding this comment.
Cool, thanks. I'm making a PR to enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add basic windows job settings
--isolation processcrashes the host Windows system.