feat: Adding support of ed25519 ssh key during scw init #1453

jeansebastienh · 2020-09-21T11:21:11Z

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fix the error during scw init: "Except for SSH key: could not find an SSH key at ~/.ssh/id_rsa.pub" if you have a key in another format.

Release note for CHANGELOG:

NONE

internal/namespaces/account/v2alpha1/custom.go

internal/namespaces/init/custom_init_ssh_test.go

Sh4d1 reviewed Sep 21, 2020

View reviewed changes

internal/namespaces/account/v2alpha1/custom.go Outdated Show resolved Hide resolved

jeansebastienh force-pushed the ssh-ed25519 branch 2 times, most recently from 5c68a48 to 07da5d5 Compare September 21, 2020 11:52

jerome-quere approved these changes Sep 21, 2020

View reviewed changes

jerome-quere suggested changes Sep 21, 2020

View reviewed changes

internal/namespaces/init/custom_init_ssh_test.go Outdated Show resolved Hide resolved

jeansebastienh added 4 commits September 22, 2020 10:12

feat: Adding support of ed25519 ssh key during scw init

dd934b5

fix: removing dsa as it's unsecure, adding ecdsa

ad94130

fix(lint): File is not goimports-ed (goimports)

ef492f3

refactor: Replace setUpSSHKeyLocally with setUpSSHKeyLocallyWithKeyName

018406a

jeansebastienh force-pushed the ssh-ed25519 branch from 07da5d5 to 018406a Compare September 22, 2020 08:18

remyleone approved these changes Sep 22, 2020

View reviewed changes

jerome-quere approved these changes Sep 22, 2020

View reviewed changes

Merge branch 'master' into ssh-ed25519

b3f37f4

jerome-quere merged commit 4db0823 into scaleway:master Sep 22, 2020

Provide feedback