Added permissions scw info
#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| fmt.Fprintln(ctx.Stdout, "Permissions:") | ||
| for _, service := range permissions.Permissions { | ||
| for key, service_name := range service { |
There was a problem hiding this comment.
don't use underscores in Go names; range var service_name should be serviceName
| } | ||
| } | ||
| fmt.Fprintf(ctx.Stdout, "\n") |
There was a problem hiding this comment.
To add a space between the two sections
There was a problem hiding this comment.
|
LGTM |
| @@ -59,9 +59,10 @@ func RunInfo(ctx CommandContext, args InfoArgs) error { | |||
| if err != nil { | |||
| return err | |||
| } else { | |||
| fmt.Fprintf(ctx.Stdout, " [%d] %s\n", id, fingerprint) | |||
| fmt.Fprintf(ctx.Stdout, " [%d] %s", id, fingerprint) | |||
There was a problem hiding this comment.
Because fingerprint has already a \n
QuentinPerez
pushed a commit
that referenced
this pull request
Sep 28, 2015
Added permissions `scw info`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191