-
Notifications
You must be signed in to change notification settings - Fork 152
Added _ips #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added _ips #196
Conversation
Address string `json:"address"` | ||
} | ||
|
||
type ScalewayGetIPS struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type ScalewayGetIPS should have comment or be unexported
LGTM for "get ips", now we need to implement some actions like attach ip to a server which is what is blocking @arianvp |
About the "attach ip to server", you can do it from the |
IPS []ScalewayIPDefinition `json:"ips"` | ||
} | ||
|
||
type ScalewayGetIP struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type ScalewayGetIP should have comment or be unexported
As the method is prefixed by But you need to move the API calls in the |
} | ||
|
||
// AttachIP attachs an IP to a server | ||
func (s *ScalewayAPI) AttachIP(idIP, serverID string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be uniform, use always ipID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups mistake idIP
-> ipID
😄
LGTM |
#178
Display the IPs
Display an IP
New IP
Delete an IP
Attach an IP