feat(args): handle scw.Duration unmarshal as flat field #3469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelax
force-pushed
the
feat/unmarshal-duration
branch
from
f1f9802 to
9b3745c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3469 +/- ##
==========================================
- Coverage 75.71% 75.70% -0.02%
==========================================
Files 175 175
Lines 39183 39190 +7
==========================================
Hits 29669 29669
- Misses 8437 8444 +7
Partials 1077 1077 ☔ View full report in Codecov by Sentry. |
scw.Duration was handled as two scalar fields
Codelax
force-pushed
the
feat/unmarshal-duration
branch
from
9b3745c to
a511779
Compare
remyleone
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scw.Duration was handled as two scalar fields
This would require a change of generator to have the durations as a flat field. Draft is available for it with # 321.