Skip to content

feat(domain): add support for SVCB and HTTPS #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat(domain): add support for SVCB and HTTPS #3989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/scw/testdata/test-all-usage-dns-record-bulk-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ARGS:
[changes.{index}.add.records.{index}.name]
[changes.{index}.add.records.{index}.priority]
[changes.{index}.add.records.{index}.ttl]
[changes.{index}.add.records.{index}.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME)
[changes.{index}.add.records.{index}.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME | SVCB | HTTPS)
[changes.{index}.add.records.{index}.comment]
[changes.{index}.add.records.{index}.geo-ip-config.matches.{index}.countries.{index}]
[changes.{index}.add.records.{index}.geo-ip-config.matches.{index}.continents.{index}]
Expand All @@ -37,14 +37,14 @@ ARGS:
[changes.{index}.add.records.{index}.id]
[changes.{index}.set.id]
[changes.{index}.set.id-fields.name]
[changes.{index}.set.id-fields.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME)
[changes.{index}.set.id-fields.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME | SVCB | HTTPS)
[changes.{index}.set.id-fields.data]
[changes.{index}.set.id-fields.ttl]
[changes.{index}.set.records.{index}.data]
[changes.{index}.set.records.{index}.name]
[changes.{index}.set.records.{index}.priority]
[changes.{index}.set.records.{index}.ttl]
[changes.{index}.set.records.{index}.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME)
[changes.{index}.set.records.{index}.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME | SVCB | HTTPS)
[changes.{index}.set.records.{index}.comment]
[changes.{index}.set.records.{index}.geo-ip-config.matches.{index}.countries.{index}]
[changes.{index}.set.records.{index}.geo-ip-config.matches.{index}.continents.{index}]
Expand All @@ -62,7 +62,7 @@ ARGS:
[changes.{index}.set.records.{index}.id]
[changes.{index}.delete.id]
[changes.{index}.delete.id-fields.name]
[changes.{index}.delete.id-fields.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME)
[changes.{index}.delete.id-fields.type] (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME | SVCB | HTTPS)
[changes.{index}.delete.id-fields.data]
[changes.{index}.delete.id-fields.ttl]
[return-all-records] Specifies whether or not to return all the records
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-dns-record-list-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ARGS:
[order-by] Sort order of the returned DNS zone records (name_asc | name_desc)
dns-zone DNS zone on which to filter the returned DNS zone records
[name] Name on which to filter the returned DNS zone records
[type] Record type on which to filter the returned DNS zone records (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME)
[type] Record type on which to filter the returned DNS zone records (unknown | A | AAAA | CNAME | TXT | SRV | TLSA | MX | NS | PTR | CAA | ALIAS | LOC | SSHFP | HINFO | RP | URI | DS | NAPTR | DNAME | SVCB | HTTPS)
[id] Record ID on which to filter the returned DNS zone records

FLAGS:
Expand Down
10 changes: 5 additions & 5 deletions docs/commands/dns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ scw dns record bulk-update <dns-zone ...> [arg=value ...]
| changes.{index}.add.records.{index}.name | | |
| changes.{index}.add.records.{index}.priority | | |
| changes.{index}.add.records.{index}.ttl | | |
| changes.{index}.add.records.{index}.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME` | |
| changes.{index}.add.records.{index}.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME`, `SVCB`, `HTTPS` | |
| changes.{index}.add.records.{index}.comment | | |
| changes.{index}.add.records.{index}.geo-ip-config.matches.{index}.countries.{index} | | |
| changes.{index}.add.records.{index}.geo-ip-config.matches.{index}.continents.{index} | | |
Expand All @@ -222,14 +222,14 @@ scw dns record bulk-update <dns-zone ...> [arg=value ...]
| changes.{index}.add.records.{index}.id | | |
| changes.{index}.set.id | | |
| changes.{index}.set.id-fields.name | | |
| changes.{index}.set.id-fields.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME` | |
| changes.{index}.set.id-fields.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME`, `SVCB`, `HTTPS` | |
| changes.{index}.set.id-fields.data | | |
| changes.{index}.set.id-fields.ttl | | |
| changes.{index}.set.records.{index}.data | | |
| changes.{index}.set.records.{index}.name | | |
| changes.{index}.set.records.{index}.priority | | |
| changes.{index}.set.records.{index}.ttl | | |
| changes.{index}.set.records.{index}.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME` | |
| changes.{index}.set.records.{index}.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME`, `SVCB`, `HTTPS` | |
| changes.{index}.set.records.{index}.comment | | |
| changes.{index}.set.records.{index}.geo-ip-config.matches.{index}.countries.{index} | | |
| changes.{index}.set.records.{index}.geo-ip-config.matches.{index}.continents.{index} | | |
Expand All @@ -247,7 +247,7 @@ scw dns record bulk-update <dns-zone ...> [arg=value ...]
| changes.{index}.set.records.{index}.id | | |
| changes.{index}.delete.id | | |
| changes.{index}.delete.id-fields.name | | |
| changes.{index}.delete.id-fields.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME` | |
| changes.{index}.delete.id-fields.type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME`, `SVCB`, `HTTPS` | |
| changes.{index}.delete.id-fields.data | | |
| changes.{index}.delete.id-fields.ttl | | |
| return-all-records | | Specifies whether or not to return all the records |
Expand Down Expand Up @@ -334,7 +334,7 @@ scw dns record list <dns-zone ...> [arg=value ...]
| order-by | One of: `name_asc`, `name_desc` | Sort order of the returned DNS zone records |
| dns-zone | Required | DNS zone on which to filter the returned DNS zone records |
| name | | Name on which to filter the returned DNS zone records |
| type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME` | Record type on which to filter the returned DNS zone records |
| type | One of: `unknown`, `A`, `AAAA`, `CNAME`, `TXT`, `SRV`, `TLSA`, `MX`, `NS`, `PTR`, `CAA`, `ALIAS`, `LOC`, `SSHFP`, `HINFO`, `RP`, `URI`, `DS`, `NAPTR`, `DNAME`, `SVCB`, `HTTPS` | Record type on which to filter the returned DNS zone records |
| id | | Record ID on which to filter the returned DNS zone records |


Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ require (
github.com/mattn/go-isatty v0.0.20
github.com/moby/buildkit v0.13.2
github.com/opencontainers/go-digest v1.0.0
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240716082911-cef39a9d4ee9
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240723092404-648ea2801f9f
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.8.1
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240716082911-cef39a9d4ee9 h1:Zo++qIasET8Dt4xwpmOt4EVgjVo/NhhZgttQfDP7VSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240716082911-cef39a9d4ee9/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240723092404-648ea2801f9f h1:xNv7pVCmf+8RmlAnALEeSNS6oGI4DFPAHt+19xY1oa8=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.29.0.20240723092404-648ea2801f9f/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=
Expand Down
10 changes: 5 additions & 5 deletions internal/namespaces/domain/v2beta1/domain_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ You can filter records by type and name.`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME"},
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME", "SVCB", "HTTPS"},
},
{
Name: "id",
Expand Down Expand Up @@ -536,7 +536,7 @@ All edits will be versioned.`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME"},
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME", "SVCB", "HTTPS"},
},
{
Name: "changes.{index}.add.records.{index}.comment",
Expand Down Expand Up @@ -646,7 +646,7 @@ All edits will be versioned.`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME"},
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME", "SVCB", "HTTPS"},
},
{
Name: "changes.{index}.set.id-fields.data",
Expand Down Expand Up @@ -689,7 +689,7 @@ All edits will be versioned.`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME"},
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME", "SVCB", "HTTPS"},
},
{
Name: "changes.{index}.set.records.{index}.comment",
Expand Down Expand Up @@ -799,7 +799,7 @@ All edits will be versioned.`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME"},
EnumValues: []string{"unknown", "A", "AAAA", "CNAME", "TXT", "SRV", "TLSA", "MX", "NS", "PTR", "CAA", "ALIAS", "LOC", "SSHFP", "HINFO", "RP", "URI", "DS", "NAPTR", "DNAME", "SVCB", "HTTPS"},
},
{
Name: "changes.{index}.delete.id-fields.data",
Expand Down
Loading