Skip to content

test: have default region overwrite the configuration file #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2020
Merged

test: have default region overwrite the configuration file #744

merged 3 commits into from
Mar 9, 2020

Conversation

remyleone
Copy link
Member

No description provided.

kindermoumoute
kindermoumoute previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me make a counter proposition

@jerome-quere jerome-quere changed the title fix: Have default region overwrite the configuration file test: have default region overwrite the configuration file Mar 6, 2020
jerome-quere
jerome-quere approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kindermoumoute
kindermoumoute approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 8d9afd0 into scaleway:v2 Mar 9, 2020
@remyleone remyleone self-assigned this Mar 9, 2020
Sh4d1 pushed a commit to Sh4d1/scaleway-cli that referenced this pull request Mar 9, 2020
@remyleone @jerome-quere @Sh4d1
test: have default region overwrite the configuration file (scaleway#744
d248edd 
)

* fix: Have default region overwrite the configuration file
Co-authored-by: Jérôme Quéré <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

@remyleone remyleone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remyleone @jerome-quere @kindermoumoute