feat(iam): creation of user as Member #3029

giacomosirri · 2025-04-07T08:17:51Z

This Pull Request implements the feature requested in the issue #3021

crlptl · 2025-04-07T10:10:42Z

Hello @giacomosirri and thank you for this PR.
The need of TF implementation for IAM members is real and we need to work on it ASAP.
We will not accept the contribution as it stands because it would have implications on member feature's future that we see differently - for example we may implement a dedicated resource scaleway_iam_member. Someone from the Scaleway team will work on this resource in the next weeks.

The guest type will disappear in the next months, and the fields you mentioned that cannot be updated will be updatable in very soon too.

However, I would like to thank you for your contribution. Can you give me your Organization-id (here or on Slack Scaleway community - Cyril Scw) so that I can put a voucher on your Organization? Thanks again

giacomosirri · 2025-04-07T12:15:29Z

Hello @crlptl,
Thank you very much for the feedback and the kind voucher proposal. I understand what you mean, it is a complex matter that probably requires more careful considerations, so I look forward to see these features fully implemented.

Anyway, the organization id is: daf36079-e52c-416c-9535-d06742e48acc.

Btw, I also tried to access the slack community from the link in the footer of the website, but it appears to be broken:

Thank you again.

Gnoale · 2025-04-30T15:15:21Z

Hello @giacomosirri, after careful consideration it happens that your approach fits well the current API state and is future proof.
I re open your PR and will make a few suggestions if you are still willing to submit it.
Thank you.

Gnoale

Thanks for your contribution, I made a few suggestion, feel free to tell me if you don't have time to work on this I would then make the changes myself

internal/services/iam/user.go

Gnoale · 2025-04-30T15:46:13Z

internal/services/iam/user.go

@@ -140,6 +236,18 @@ func resourceIamUserUpdate(ctx context.Context, d *schema.ResourceData, m interf
 		return diag.FromErr(err)
 	}

+	/*


Please remove this comment it should be now supported

docs/resources/iam_user.md

internal/services/iam/user.go

Gnoale · 2025-04-30T16:00:58Z

internal/services/iam/user_test.go

+					resource.TestCheckResourceAttr("scaleway_iam_user.guest_user", "tags.#", "2"),
+					resource.TestCheckResourceAttr("scaleway_iam_user.guest_user", "tags.0", "tf_tests"),
+					resource.TestCheckResourceAttr("scaleway_iam_user.guest_user", "tags.1", "tests"),
+					// The username is the same as the email for Guest users.


remove comment

internal/services/iam/user.go

giacomosirri · 2025-05-07T07:14:35Z

Hello @Gnoale, thank you for the update, that's good to hear!
I will take the time to work on it and update the code based on your suggestions. I might be able to submit it within this week, at the latest next week.

…e API

giacomosirri · 2025-05-15T11:00:50Z

@Gnoale @remyleone hello,
I'm pinging you here just to let you know that I have implemented the requested changes.
The acceptance tests were all ok and as far as I can tell now everything works pretty much as I would expect. However, if you notice something wrong, please let me know so that I can fix it!
Thank you

Gnoale

Hello @giacomosirri thanks for you work, I made another review pass, it is almost good I think

I suggest we remove the ForceNew flag from the "email" field and return an error in case of a guest email update attempt.
Since guest will be deprecated

We could add a hint about this behavior in the documentation too

What do you think @remyleone @crlptl

Gnoale · 2025-05-15T15:19:42Z

internal/services/iam/user.go

@@ -23,20 +23,63 @@ func ResourceUser() *schema.Resource {
 		},
 		SchemaVersion: 0,
 		Schema: map[string]*schema.Schema{
+			"organization_id": account.OrganizationIDOptionalSchema(),
+			// User input data
 			"email": {
 				Type:        schema.TypeString,
 				Required:    true,


remove ForceNew

Description: "The email of the iam user, in case of a member, this field is not editable",

Gnoale · 2025-05-15T15:22:19Z

internal/services/iam/user.go

+			}, scw.WithContext(ctx))
+			if err != nil {
+				return diag.FromErr(err)
+			}


Suggested change

}

}

if d.HasChange("email") {

return diag.FromErr(fmt.Errorf("The email of a guest user cannot be updated, you need to create a new user"))

}

Gnoale · 2025-05-15T15:22:39Z

internal/services/iam/user.go

+			}
+		}
+	} else {
+		/*


Gnoale · 2025-05-15T15:22:57Z

internal/services/iam/user.go

+		 * For this reason, even though the IAM API supports it, the email is not considered
+		 * an updatable field here.
+		 */
+		if d.HasChanges("tags", "first_name", "last_name", "phone_number", "locale") {


Suggested change

if d.HasChanges("tags", "first_name", "last_name", "phone_number", "locale") {

if d.HasChanges("tags", "first_name", "last_name", "phone_number", "locale", "email") {

Gnoale · 2025-05-15T15:23:18Z

internal/services/iam/user.go

+				FirstName:   scw.StringPtr(d.Get("first_name").(string)),
+				LastName:    scw.StringPtr(d.Get("last_name").(string)),
+				PhoneNumber: scw.StringPtr(d.Get("phone_number").(string)),
+				Locale:      scw.StringPtr(d.Get("locale").(string)),


Suggested change

Locale: scw.StringPtr(d.Get("locale").(string)),

Locale: scw.StringPtr(d.Get("locale").(string)),

Email: scw.StringPtr(d.Get("email").(string)),

Gnoale · 2025-05-15T15:24:47Z

internal/services/iam/user_test.go

+			{
+				Config: `
+					resource "scaleway_iam_user" "member_user" {
+						email = "[email protected]"


Suggested change

email = "foo@scaleway.com"

email = "foobar@scaleway.com"

Gnoale · 2025-05-15T15:25:08Z

internal/services/iam/user_test.go

+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckIamUserExists(tt, "scaleway_iam_user.member_user"),
+					acctest.CheckResourceAttrUUID("scaleway_iam_user.member_user", "id"),
+					resource.TestCheckResourceAttr("scaleway_iam_user.member_user", "email", "[email protected]"),


Suggested change

resource.TestCheckResourceAttr("scaleway_iam_user.member_user", "email", "foo@scaleway.com"),

resource.TestCheckResourceAttr("scaleway_iam_user.member_user", "email", "foobar@scaleway.com"),

giacomosirri requested review from a team and remyleone as code owners April 7, 2025 08:17

github-actions bot added the iam IAM issues, bugs and feature requests label Apr 7, 2025

remyleone changed the title ~~feature #3021: (IAM) Creation of user as Member~~ feat(iam): creation of user as Member Apr 7, 2025

remyleone closed this Apr 7, 2025

Gnoale reopened this Apr 30, 2025

Gnoale force-pushed the member-user-creation branch from cbafdfd to 9fcac44 Compare April 30, 2025 15:17

Gnoale reviewed Apr 30, 2025

View reviewed changes

giacomosirri force-pushed the member-user-creation branch from 9fcac44 to ab57ce0 Compare May 14, 2025 15:58

giacomosirri added 14 commits May 15, 2025 12:54

Distinguish between Member users and Guest users in user creation

24b5ae9

Add all API parameters to resource schema

30ab2d7

Complete implementation of user creation

70f3e31

Add fields to user read function

fa16393

Fix schema of some parameters

33c471d

Reimplement acceptance tests to test creation for both user types

57fa93a

Complete acceptance tests

6e5cd04

Add comments

351d3ec

Final test runs: no errors

e12313f

Update docs

121d9f6

Update CRUD operations for the User resource to reflect changes in th…

ef580bf

…e API

Fix typo in docs

565c04d

Update acceptance tests

20a48cf

Add support for username update

344f1e8

giacomosirri force-pushed the member-user-creation branch from 3282040 to 344f1e8 Compare May 15, 2025 10:55

Gnoale reviewed May 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iam): creation of user as Member #3029

feat(iam): creation of user as Member #3029

giacomosirri commented Apr 7, 2025

crlptl commented Apr 7, 2025 •

edited

Loading

giacomosirri commented Apr 7, 2025

Gnoale commented Apr 30, 2025

Gnoale left a comment

Gnoale Apr 30, 2025

Gnoale Apr 30, 2025

giacomosirri commented May 7, 2025

giacomosirri commented May 15, 2025

Gnoale left a comment

Gnoale May 15, 2025

Gnoale May 15, 2025

Gnoale May 15, 2025 •

edited

Loading

Gnoale May 15, 2025

Gnoale May 15, 2025

Gnoale May 15, 2025

Gnoale May 15, 2025

Gnoale May 15, 2025

-			}
+			}
+		if d.HasChange("email") {
+			return diag.FromErr(fmt.Errorf("The email of a guest user cannot be updated, you need to create a new user"))
+		}

	if d.HasChanges("tags", "first_name", "last_name", "phone_number", "locale") {
	if d.HasChanges("tags", "first_name", "last_name", "phone_number", "locale", "email") {

	Locale: scw.StringPtr(d.Get("locale").(string)),
	Locale: scw.StringPtr(d.Get("locale").(string)),
	Email: scw.StringPtr(d.Get("email").(string)),

	resource.TestCheckResourceAttr("scaleway_iam_user.member_user", "email", "foo@scaleway.com"),
	resource.TestCheckResourceAttr("scaleway_iam_user.member_user", "email", "foobar@scaleway.com"),

feat(iam): creation of user as Member #3029

Are you sure you want to change the base?

feat(iam): creation of user as Member #3029

Conversation

giacomosirri commented Apr 7, 2025

crlptl commented Apr 7, 2025 • edited Loading

giacomosirri commented Apr 7, 2025

Gnoale commented Apr 30, 2025

Gnoale left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giacomosirri commented May 7, 2025

giacomosirri commented May 15, 2025

Gnoale left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gnoale May 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crlptl commented Apr 7, 2025 •

edited

Loading

Gnoale May 15, 2025 •

edited

Loading