Skip to content

Use markdown links (not relref or ref shortcodes) #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jarrodmillman opened this issue Mar 26, 2024 · 2 comments
Closed

Use markdown links (not relref or ref shortcodes) #568

jarrodmillman opened this issue Mar 26, 2024 · 2 comments
Assignees

Comments

@jarrodmillman
Copy link
Member

jarrodmillman commented Mar 26, 2024

Hugo 0.122 added link render hooks (so we don't need to use the relref or ref shortcodes anymore): https://gohugo.io/render-hooks/links/

See scientific-python/learn.scientific-python.org#146 for example.

@alphapapa
Copy link
Contributor

@jarrodmillman I've pushed PRs for these repos, all of the ones I could find that use relref or ref links in their content:

Please let me know if I've missed any, or if any other changes are needed. Thanks.

jarrodmillman pushed a commit to numpy/numpy.org that referenced this issue Apr 11, 2024
jarrodmillman added a commit to scientific-python/scientific-python.org that referenced this issue Apr 11, 2024
* Use markdown links

See <scientific-python/scientific-python-hugo-theme#568>.

* Apply suggestions from code review

---------

Co-authored-by: Jarrod Millman <[email protected]>
jarrodmillman added a commit to scientific-python/specs that referenced this issue Apr 11, 2024
See
<scientific-python/scientific-python-hugo-theme#568>.

- [x] **NOTE:** Before this PR is applied, the theme submodule needs to
be updated so that Hugo v0.123+ is used. I'm not sure what other
implications that has, if any. @jarrodmillman: Please let me know if I
should also push a commit to this PR that upgrades the theme version.

@jarrodmillman @stefanv I'm unable to assign PRs and suggest reviewers
on this repo, so tagging you this way. Thanks.

---------

Co-authored-by: Jarrod Millman <[email protected]>
@jarrodmillman
Copy link
Member Author

Thanks! I merged the ones that were ready to go (or only needed slight tweaking). The blog one looks like it has more tweaks needed, which I will for you to sort out. I will review once the CI passes.

alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
alphapapa added a commit to alphapapa/blog.scientific-python.org that referenced this issue Apr 23, 2024
jarrodmillman pushed a commit to scientific-python/blog.scientific-python.org that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants