-
Notifications
You must be signed in to change notification settings - Fork 36
ci: do arm64 builds natively on TravisCI #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70f9f8b
to
d067349
Compare
d193b7f
to
2e84554
Compare
After several iterations with the parts of the CI that are difficult to test locally, I think I have everything working correctly now. The only part left that I don't know how to test is the final deploy step. The resulting wheel for arm64 bundles the openssl libraries with it. I started out using the openssl library from the container, but switched back to the version 1.1.1h downloaded from openssl.org because the version in the container has a bunch of other dynamic library dependencies that I didn't want to pull in with this wheel.
|
@thewtex Can you take a look at this PR or mention someone else who can? Thanks! |
@AWSjswinney thanks again! Looks good. TravisCI.com was enabled, but now the repository needs to be enabled. @jcfr could you please enable at: |
Thanks for the note. Doing so now. |
I migrated all repos from scikit-build org to travis.com, let me know if you need anything else to move forward with this. |
@jcfr thanks! Looks good. @AWSjswinney could you please address @jcfr's inline comments? |
I made the requested changes. Let me know if you see anything else you'd like changed. |
@AWSjswinney Thanks for the update. TravisCI.com is running now -- it seems to have caught an issue:
|
Ah, yes. That's why automated tests exist! I pushed another update. |
Thanks! I look forward to seeing the published wheel in pypi! |
Thanks @thewtex and @AWSjswinney for working on this 🙏 |
Fixes #115
Build arm64 wheel on Travis CI in order to build natively, instead of cross compiling from x86_64. This fixes several problems with the Arm wheel. It makes use of
arch: arm64-graviton2
, which is currently only available on travis-ci.com. It is probably possible to build the project on travis-ci.org witharch: arm64
instead, but it will be significantly slower.See #115 for more information.