Skip to content

fix travis twine and prepare for release #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

fix travis twine and prepare for release #40

merged 2 commits into from
May 7, 2021

Conversation

AWSjswinney
Copy link
Contributor

I made some similar changes as were necessary for cmake. I also updated the readme, to link to the correct Travis builds. After merging this PR, could you make a tag to upload a new release to pypi?

@AWSjswinney AWSjswinney mentioned this pull request Dec 4, 2020
Closed
@AWSjswinney
Copy link
Contributor Author

Looks like this failures are caused by a regression in the bdist_wheel code. See the linked issue above.

@jcfr
Copy link
Contributor

jcfr commented Dec 4, 2020

Looks like this failures are caused by a regression

Thanks for following up on this 🙏

Based on the upstream project answer, I guess we could mitigate the issue by installing an older version of wheel if python 2.7 is used ?

@AWSjswinney
Copy link
Contributor Author

The Python 2.7 issues is resolved now, but there are still some other problems that seem like they're probably unrelated too. I'm looking to see what can be down about those problems.

@AWSjswinney AWSjswinney force-pushed the master branch 4 times, most recently from 71b20ac to 5d0d6af Compare December 17, 2020 19:56
@AWSjswinney
Copy link
Contributor Author

AWSjswinney commented Dec 17, 2020 •
edited
Loading

@jcfr Can I get you to take a look at the mac build for Python 3? I'm not sure what's wrong and the error messages are not helping me:
https://travis-ci.com/github/scikit-build/ninja-python-distributions/jobs/461954832
Thank you!

@thewtex
Copy link
Member

thewtex commented Jan 9, 2021

Perhaps GitHub Actions instead for the Travis build?

@mayeut mayeut mentioned this pull request May 2, 2021
Merged
@henryiii
Copy link
Contributor

henryiii commented May 7, 2021

This was fixed in #43, so I've just kept the README changes.

@henryiii
Copy link
Contributor

henryiii commented May 7, 2021

@jcfr looks like you renamed the file but didn't update where it was getting called, perhaps?

@jcfr
Copy link
Contributor

jcfr commented May 7, 2021

looks like you renamed the file but didn't update where it was getting called, perhaps?

Good point, I missed that. I will split the commit and address the renaming issue.

@jcfr jcfr merged commit 98c811f into scikit-build:master May 7, 2021
@AWSjswinney AWSjswinney mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AWSjswinney @jcfr @thewtex @henryiii